-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace installation: Support externally managed themes #99761
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~15 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -111,9 +115,16 @@ const MarketplaceProductInstall = ( { | |||
isMarketplaceProductSelector( state, pluginSlug ) | |||
); | |||
|
|||
const wpOrgTheme = useSelector( ( state ) => getTheme( state, 'wporg', themeSlug ) ); | |||
const externalTheme = useSelector( ( state ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to externalTheme
since it's not necessarily a wp.org theme, but "external" might sound too much like "externally managed" aka partner themes, so open to other suggestions.
Related to #95651
Proposed Changes
Update the marketplace theme install to support "externally managed" themes (partner themes).
Why are these changes being made?
We want to use the marketplace install process to install both community and partner themes, since it handles the atomic transfer. Currently it works, more by accident— because it still installs the theme even though it doesn't recognize it as a community theme.
Testing Instructions
/marketplace/theme/<theme slug>/install/<site>
Pre-merge Checklist