Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace installation: Support externally managed themes #99761

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ryelle
Copy link
Member

@ryelle ryelle commented Feb 13, 2025

Related to #95651

Proposed Changes

Update the marketplace theme install to support "externally managed" themes (partner themes).

Why are these changes being made?

We want to use the marketplace install process to install both community and partner themes, since it handles the atomic transfer. Currently it works, more by accident— because it still installs the theme even though it doesn't recognize it as a community theme.

Testing Instructions

  • Gather a few community and partner themes to test with
  • Manually enter the marketplace install route, e.g., /marketplace/theme/<theme slug>/install/<site>
  • You should see the correct thumbnail and theme title, not the theme slug
  • The install process should work, assuming you have purchased the partner theme subscription
Before After

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ryelle ryelle self-assigned this Feb 13, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/marketplace-install-partner-themes on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
marketplace        +57 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -111,9 +115,16 @@ const MarketplaceProductInstall = ( {
isMarketplaceProductSelector( state, pluginSlug )
);

const wpOrgTheme = useSelector( ( state ) => getTheme( state, 'wporg', themeSlug ) );
const externalTheme = useSelector( ( state ) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to externalTheme since it's not necessarily a wp.org theme, but "external" might sound too much like "externally managed" aka partner themes, so open to other suggestions.

@ryelle ryelle marked this pull request as ready for review February 13, 2025 22:50
@Copons Copons requested a review from a team February 14, 2025 17:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Marketplace [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants