Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: improve Download CSV consistency #99763

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

myhro
Copy link
Contributor

@myhro myhro commented Feb 13, 2025

Closes Automattic/jetpack-roadmap/issues/2241.

Proposed Changes

  • Improve Download CSV action consistency for almost all cards, except UTM and Videos that have different designs.

Why are these changes being made?

  • Automattic/jetpack-roadmap#1818

Testing Instructions

  • Access the Calypso live link below and go to a site that has meaningful data, like /stats/day/jetpack.com.
  • Click on View all/View details links for different cards. The Download CSV button should be shown in the upper-right corner.
    • There will be a second row/sub-header, where the metric (like Views) will be now part of.
  • This is how Posts & pages, for example, should look like:
Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Feb 13, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~64 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +285 B  (+0.0%)      +64 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@myhro myhro force-pushed the fix/stats-improve-download-csv branch from 436276d to 85194e7 Compare February 14, 2025 10:59
@matticbot
Copy link
Contributor

matticbot commented Feb 14, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/stats-improve-download-csv on your sandbox.

@myhro myhro force-pushed the fix/stats-improve-download-csv branch from 17b1cf2 to 1b886a4 Compare February 15, 2025 02:43
@myhro myhro changed the title [WIP] Stats: improve Download CSV consistency Stats: improve Download CSV consistency Feb 15, 2025
@myhro myhro added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 15, 2025
@myhro myhro requested review from Initsogar and a team February 15, 2025 03:14
@myhro myhro marked this pull request as ready for review February 15, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants