Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader User Profile: Refactor CSS #99765

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

artemiomorales
Copy link
Contributor

@artemiomorales artemiomorales commented Feb 13, 2025

Related to #99286

Proposed Changes

This refactors the user profile page's CSS to make better use of SASS syntax.

Why are these changes being made?

The stylesheet for the profile page is disorganized.
Naming and SASS syntax is inconsistent, and it’s hard to add styles to it cleanly; this PR makes the styles more consistent so they're easier to maintain and understand.

Testing Instructions

On the profile page...

  • Make sure the padding is still being applied to user-profile__wrapper and user-profile__wrapper-content at desktop and mobile widths, and that the back button looks correct.
  • Visit a nonexistent profile like /reader/users/artemiosansafd and make sure the styles still render properly for empty content.
  • Visit the lists page and make sure those styles are still being applied.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@artemiomorales artemiomorales added the [Feature] Reader The reader site on Calypso. label Feb 13, 2025
@artemiomorales artemiomorales marked this pull request as ready for review February 13, 2025 22:21
@artemiomorales artemiomorales requested a review from a team as a code owner February 13, 2025 22:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 13, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 13, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/reader-user-profile-styles on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@artemiomorales artemiomorales self-assigned this Feb 13, 2025
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artemiomorales artemiomorales merged commit 326822f into trunk Feb 14, 2025
13 checks passed
@artemiomorales artemiomorales deleted the update/reader-user-profile-styles branch February 14, 2025 17:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants