Add {function_name}_with_fn type functions for RemoteExt #208
Conversation
citadel_sdk/src/remote_ext.rs
Outdated
| self.can_use_revfs()?; | ||
| let request = NodeRequest::DeleteObject(DeleteObject { | ||
| v_conn: *self.user(), | ||
| virtual_dir: virtual_directory.into(), | ||
| security_level: Default::default(), | ||
| }); | ||
| let status = self.remote().send_callback(request).await?; |
There was a problem hiding this comment.
Recall that our issue is that when peers are behind the same kernel, there can be false positive matches when the tickets match. We also needed to check CIDs. The send_callback and send_callback_subscription functions only check for ticket matching; send_callback only waits for the first signal to come back, whereas send_callback_subscription streams signals until a signal we want comes through. Since we now require the possibility of multiple signals, we will need to upgrade send_callback to send_callback_subscription, since in the IS, we may get a ticket match but not a CID match and will need to reroute that signal, then keep waiting. So, everywhere that we do a send_callback, we will need to upgrade it to the streaming version.
| @@ -351,8 +351,8 @@ pub enum KemAlgorithm { | |||
| )] | |||
| pub enum SigAlgorithm { | |||
| #[default] | |||
| None = 0, | |||
| Falcon1024 = 1, | |||
| Falcon1024 = 0, | |||
There was a problem hiding this comment.
Keep None as 0, just shift the default tag down to Falcon. This keeps the encoding consistent between protocol versions, so there are no surprises. Otherwise, we would need to update the protocol versions.
No description provided.