Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: suspend specific cronJob when deactivation action is requested & block automatic cronjob creation on a specific namespace #97

Merged
merged 2 commits into from
Feb 25, 2025
Merged

feat: suspend specific cronJob when deactivation action is requested & block automatic cronjob creation on a specific namespace #97

merged 2 commits into from
Feb 25, 2025

Conversation

Franck-Aymar-Braffouo
Copy link
Collaborator

No description provided.

@Franck-Aymar-Braffouo Franck-Aymar-Braffouo force-pushed the feature/suspend-cronjob-and-prod-namespace-regex branch from 32abcc6 to fb87d60 Compare February 5, 2025 16:27
@Franck-Aymar-Braffouo Franck-Aymar-Braffouo changed the title feat: suspend specific cronJob when deactivation action is requested feat: suspend specific cronJob when deactivation action is requested & block automatic cronjob creation on a specific namespace Feb 6, 2025
@Franck-Aymar-Braffouo Franck-Aymar-Braffouo force-pushed the feature/suspend-cronjob-and-prod-namespace-regex branch from 6c00580 to 670f697 Compare February 7, 2025 11:03
@Franck-Aymar-Braffouo Franck-Aymar-Braffouo force-pushed the feature/suspend-cronjob-and-prod-namespace-regex branch from 670f697 to 216fa12 Compare February 7, 2025 11:29
guillaume-chervet
guillaume-chervet reviewed Feb 17, 2025
View reviewed changes
api/api/src/test/java/fr/axa/openpaas/dailyclean/util/NamespaceVerifierTest.java

class NamespaceVerifierTest {

public static final String GIVEN_REGEX = "-prod-fr";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es ce qu'il y a moyen de surcharger cette valeur par défault?

Es-ce possible de mettre a jour le README pour expliquer comment ? et pourquoi cette fonctionnalité ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vu le contexte Open Source, je suis parti du fait qu'on laisserait la latitude à chaque projet/organisation de la définir, pour éviter des éventuels breaking change.

"Es-ce possible de mettre a jour le README pour expliquer comment ? et pourquoi cette fonctionnalité ?"

yes, bonne idée. Je fais ca.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/AxaFrance/dailyclean/compare/216fa1274690ef13bab5aa3251e51320b0c96c28..863a50124f8837198dadba3fd6146ee8e104ca20

@Franck-Aymar-Braffouo Franck-Aymar-Braffouo force-pushed the feature/suspend-cronjob-and-prod-namespace-regex branch from 216fa12 to 863a501 Compare February 17, 2025 12:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Franck-Aymar-Braffouo Franck-Aymar-Braffouo merged commit 47df104 into main Feb 25, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume-chervet guillaume-chervet guillaume-chervet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Franck-Aymar-Braffouo @guillaume-chervet