Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improve contributor xp #8
base: master
Are you sure you want to change the base?
Feature/improve contributor xp #8
Changes from 3 commits
d3ae99e
1d48c1d
dfdd031
4d90a15
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le détails des scripts ne me semblent pas utile ici. Le développeur a l'habitude de les trouver dans le package.json. @samuel-gomez-axa ton avis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perso, je trouve ça pas mal d'expliquer la fonction de chaque script, faudra juste veiller à maintenir la doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus design system que toolkit ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non, justement, l'idée est de dire qu'on affiche ici la documentation en lien avec le toolkit.
Je peux tourner la phrase différemment:
This design system is implemented by the react-toolkit
Est-ce plus clair?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai pushé un fix. A vous de me dire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas tout a fait d'accord car le design system est le point d'entré et le toolkit l'implémentation de ce design system. Un nouveau composant doit être documenté avant d'être implémenter. C'est pour cela qu'il n'y a pas de lien design-system vers toolkit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parfait, ça me va!
Sauf, justement un lien pour dire que le react-toolkit implémente ce design system, c'est une information importante.
Si un jour un autre toolkit vient l'implémenter (e.g. svelte-toolkit ou autre), on pourra rajouter le lien vers cette nouvelle implémentation. Qu'en pensez-vous?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai pushé un fix. A vous de me dire.