-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add freqAnalyzer strategy #1444
Conversation
The test failures don't seem to be related to your contribution. For example:
I'd still like to investigate what is happening here though. I wonder if this could be related to numpy's Here's what
|
Yep, looks like numpy installation is the issue. I'm seeing this error in my local jupyter notebook I'm using for testing:
New numpy release is incompatible with older version of matplotlib and for some reason, pip's dependency resolver wasn't working properly. I was able to resolve locally by upgrading pip, numpy, and matplotlib. |
A few tests are failing:
|
1cec30e
to
d706204
Compare
Hello @miller-ian 👋🏻 The tests are failing at your The opponent hasn't defected yet, so in your player's mind, there has only been cooperation. Therefore, it will keep cooperating. Actually your opponent based on the
|
yep was a bit confused about the format of the test inputs but should be working now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for coming back to this! Just a few minor comments on potential style / comment improvements.
No description provided.