Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build moran benchmark #1467

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Build moran benchmark #1467

wants to merge 3 commits into from

Conversation

gaffney2010
Copy link
Member

This benchmark was used to analyze #1460.

There's a way to integrate pytest-benchmark with tox. This PR doesn't do that, but may be a good starting point.

@gaffney2010 @drvinceknight
Use python -m pip
3f6d99f 
Co-authored-by: Vince Knight <[email protected]>
@drvinceknight
Copy link
Member

Ok so the CI is failing for an upstream change in pandas (I THINK). The fix is to remove an unused line in the result_set file:. This commit 9e8092c on #1469 shows what's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drvinceknight drvinceknight drvinceknight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaffney2010 @drvinceknight