Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ask prompts to allow prompt override/injection #2277

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

pamelafox
Copy link
Collaborator

Purpose

In my most recent PR, to prompt to Prompty, I accidentally removed the ability to override the prompt template for the Ask tab. In fixing this, I discovered that we never had the ability to inject to the end of the prompt for the Ask tab. We should have both override/inject for both tabs, since the developer settings indicates it's possible for both of them.

I added tests to verify the changes, as we were missing tests for this before.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No

Type of change

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@@ -10,11 +10,17 @@ sample:
- "role_library.pdf#page=23: Company: Contoso Electronics Location: Anywhere Job Type: Full-Time Salary: Competitive, commensurate with experience Job Summary: The Senior Manager of Product Management will be responsible for leading the product management team at Contoso Electronics. This role includes developing strategies, plans and objectives for the product management team and managing the day-to-day operations. The Senior Manager of Product Management will be responsible for the successful launch of new products and the optimization of existing products. Responsibilities: · Develop and implement product management strategies, plans and objectives to maximize team performance. · Analyze competitive landscape and market trends to develop product strategies. · Lead the product management team in the development of product plans, roadmaps and launch plans. · Monitor the performance of product management team, analyze results and implement corrective action as needed. · Manage the product lifecycle, including product development, launch, and end of life. · Ensure product features and benefits meet customer requirements. · Establish and maintain relationships with key customers, partners, and vendors."
- "role_library.pdf#page=28: · 7+ years of experience in research and development in the electronics sector. · Proven track record of successfully designing, testing, and optimizing products. · Experience leading a team of researchers and engineers. · Excellent problem-solving and analytical skills. · Ability to work in a fast-paced environment and meet tight deadlines.· Knowledge of industry trends, technologies, and regulations. · Excellent communication and presentation skills. Manager of Product Management Job Title: Manager of Product Management, Contoso Electronics Job Summary: The Manager of Product Management is responsible for overseeing the product management team, driving product development and marketing strategy for Contoso Electronics. This individual will be accountable for the successful launch of new products and the implementation of product life-cycle management processes. The Manager of Product Management will collaborate with internal teams, such as engineering, sales, marketing, and finance, as well as external partners, suppliers, and customers to ensure successful product execution."
---
system:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added "system:" to each Prompty file. That's not strictly required for the Prompty python package, but Azure AI Foundry expects it when you import a Prompty file into the Chat playground.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • app/backend/approaches/prompts/ask_answer_question.prompty: Language not supported
  • app/backend/approaches/prompts/ask_answer_question_vision.prompty: Language not supported
  • app/backend/approaches/prompts/chat_answer_question.prompty: Language not supported
  • app/backend/approaches/prompts/chat_answer_question_vision.prompty: Language not supported
  • tests/snapshots/test_app/test_ask_prompt_template/client0/result.json: Language not supported
  • tests/snapshots/test_app/test_ask_prompt_template/client1/result.json: Language not supported
  • tests/snapshots/test_app/test_ask_prompt_template_concat/client0/result.json: Language not supported
  • tests/snapshots/test_app/test_ask_prompt_template_concat/client1/result.json: Language not supported
@mattgotteiner
Copy link
Collaborator

Thanks for improving our test coverage here!

@pamelafox pamelafox merged commit a0cbcf5 into Azure-Samples:main Jan 16, 2025
11 checks passed
@pamelafox pamelafox deleted the promptytweaks branch January 16, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants