Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix - codify solution to another make generate issue on MacOS #3900

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kimorris27
Copy link
Contributor

Which issue this PR addresses:

No Jira; addresses a small issue I encountered in my own work.

What this PR does / why we need it:

This ensures that uber-go/mock#185 is always fixed automatically for MacOS users.

I'm not sure why, but I found in the course of my work that I had to run the codesign command again even though I figured it was a one time fix. It must be related to the fact that make install-tools is rerun each time you make generate. So I figured I'd codify the fix.

Test plan for issue:

Only relevant for MacOS users. Run make generate and make sure you don't run into uber-go/mock#185.

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

N/A

@kimorris27
Copy link
Contributor Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bitoku
bitoku previously approved these changes Oct 11, 2024
Copy link
Collaborator

@bitoku bitoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
We may want to change install-tools target instead, because it's a kind of part of the installation for macOS users, probably?

@kimorris27 kimorris27 force-pushed the kimorris27/hotfix-mockgen-codesign-issue-on-macos branch from db0b10c to c6e13d9 Compare October 14, 2024 14:10
@kimorris27
Copy link
Contributor Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@bitoku bitoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked in my macOS env.

@bitoku bitoku merged commit 37e6171 into master Oct 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants