Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement to Unit-Test-Policies workflow #1402

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Enhancement to Unit-Test-Policies workflow #1402

merged 6 commits into from
Aug 9, 2023

Conversation

Springstone
Copy link
Member

Overview/Summary

Adding condition for version comparison check and new tests for deprecated custom policies.

This PR fixes/adds/changes/removes

  1. unit-test-policies workflow
  2. Added a default placeholder value for workspace parameter in deprecated policy Deny-Nsg-FlowLogs-to-LA.json

@Springstone Springstone added enhancement New feature or request engineering engineering work PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Aug 9, 2023
@Springstone Springstone requested a review from a team as a code owner August 9, 2023 13:07
@github-actions github-actions bot requested a review from a team as a code owner August 9, 2023 13:07
jtracey93
jtracey93 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 236a023 into Azure:main Aug 9, 2023
1 check passed
@Springstone Springstone deleted the UpdateUnitTest branch August 9, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
engineering engineering work enhancement New feature or request PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Springstone @jtracey93