Rename inconsistent policy files

[rozkurt]

Overview/Summary

Fixed issue with couple of Policy Definitions file names to align with the actual name of the policies

This PR fixes/adds/changes/removes

1. Renamed following files:
   Audit-PrivateLinkPrivateDnsZones.json --> Audit-PrivateLinkDnsZones.json
DenyAction-ActivityLogSettings.json --> DenyAction-ActivityLogs.json
DenyAction-DiagnosticSettings.json --> DenyAction-DiagnosticLogs.json

Breaking Changes

1. N/A

Testing Evidence

Testing URLs

Azure Public

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Ensured contribution guidance is followed.
• Updated relevant and associated documentation.
• Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

[jtracey93]

Nice work @rozkurt

I checked all files and policies with the below script and you've got them all covered 👍

# get all of the policies in src/resources/microsoft.authorization/policyDefinitions and check the file name, wihtout the extension, matches the policy name in the propoerty of the json file

$policyDefinitions = Get-ChildItem -Path .\src\resources\microsoft.authorization\policyDefinitions -Filter *.json -Recurse -Exclude *.AzureChinaCloud.json, *.AzureUSGovernment.json

$policyDefinitions | ForEach-Object {
  $policyDefinition = Get-Content $_.FullName | ConvertFrom-Json
  $policyName = $policyDefinition.name
  $fileName = $_.Name.Replace(".json", "")
  if ($policyName -ne $fileName) {
    Write-Host "Policy name '$policyName' does not match file name '$fileName' in file '$($_.FullName)'" -ForegroundColor Red
  }
  else {
    Write-Host "Policy name '$policyName' does match file name '$fileName' in file '$($_.FullName)'" -ForegroundColor Green
  }
}

# get all of the policies in src/resources/microsoft.authorization/policySetDefinitions and check the file name, wihtout the extension, matches the policy name in the propoerty of the json file

$policySetDefinitions = Get-ChildItem -Path .\src\resources\microsoft.authorization\policySetDefinitions -Filter *.json -Recurse -Exclude *.AzureChinaCloud.json, *.AzureUSGovernment.json

$policySetDefinitions | ForEach-Object {
  $policyDefinition = Get-Content $_.FullName | ConvertFrom-Json
  $policyName = $policyDefinition.name
  $fileName = $_.Name.Replace(".json", "")
  if ($policyName -ne $fileName) {
    Write-Host "Policy name '$policyName' does not match file name '$fileName' in file '$($_.FullName)'" -ForegroundColor Red
  }
  else {
    Write-Host "Policy name '$policyName' does match file name '$fileName' in file '$($_.FullName)'" -ForegroundColor Green
  }
}

[jtracey93]

LGTM