Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal RI: Fix IP address space overlap with FW/VPN #1443

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Portal RI: Fix IP address space overlap with FW/VPN #1443

merged 4 commits into from
Oct 17, 2023

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Oct 10, 2023 •
edited
Loading

Overview/Summary

Fixes issue #1427 (tracked in AB#30877)
Address an IP address overlap when deploying a VPN gateway and Azure Firewall (Basic).

This PR fixes/adds/changes/removes

  1. Portal UI

Breaking Changes

  1. N/A

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone requested a review from a team as a code owner October 10, 2023 07:21
@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Oct 10, 2023
@jtracey93 jtracey93 linked an issue Oct 11, 2023 that may be closed by this pull request
Address range overlaps for AZFW management subnet if deployed the defaults with a VPN gateway #1427
Closed
@jtracey93 jtracey93 closed this Oct 11, 2023
@jtracey93 jtracey93 reopened this Oct 11, 2023
@jtracey93 jtracey93 temporarily deployed to csu-rw October 11, 2023 07:45 — with GitHub Actions Inactive
@jtracey93 jtracey93 merged commit 726b55b into Azure:main Oct 17, 2023
3 of 4 checks passed
@Springstone Springstone deleted the GH1427 branch October 17, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address range overlaps for AZFW management subnet if deployed the defaults with a VPN gateway
2 participants
@Springstone @jtracey93