Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates azure.yaml schema for deployment stacks configuration #4358

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Sep 19, 2024

Important

Do not merge till after release

Updates the alpha schema for azure.yaml to include the optional deployment stacks configuration.

The deploymentStacks property will light up when provider: bicep. When specifying the deploymentStacks property the user must configure at least one of the properties otherwise the whole property can be omitted and use the internal defaults.

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time I see one of these PRs I feel like I learn a little more about JSON Schema. Thanks for the updates here, @wbreza and for being a wizard at this stuff! LGTM.

schemas/alpha/azure.yaml.json Show resolved Hide resolved
schemas/alpha/azure.yaml.json Outdated Show resolved Hide resolved
@wbreza
Copy link
Contributor Author

wbreza commented Oct 9, 2024

/check-enforcer override

@wbreza wbreza enabled auto-merge (squash) October 9, 2024 22:40
@wbreza wbreza merged commit 311eed5 into Azure:main Oct 9, 2024
4 checks passed
@wbreza wbreza deleted the deployment-stacks-schema branch October 9, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment Stacks: Support Customization of Deny and Detach settings
2 participants