-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the feature to include golangci-lint
since it's already included with ghcr.io/devcontainers/features/go:1
#4506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PabloZaiden thank you for your contribution!
Can you reference any existing artifacts (issues, discussions, PRs) that describes how ownership is being transferred from https://github.com/guiyomh/features to https://github.com/PabloZaiden/devcontainers-features, since it is a fork? From the changeset here, it looks like the changes made are largely just around release management.
Correct if me if I'm wrong, but the arm64 feature support was actually done as part of guiyomh/features#37?
Based on this initial look, I'm going to wait on understanding more about what conversations has been had with the original author guiyomh in the strategy here before providing an approval. Thanks!
@weikanglim I've contacted the owner of the original repo to ask him to generate new releases since, after that fix (and several other too), they never generated new releases for the devcontainer features. I'd gladly revert it back to the original repo if it's being regularly updated, but even when the last commit was from 11-30-2023, the last build used by the devcontainers is from mid 2022. Until that is properly fixed, this issue is blocking development on ARM based computers. (well... blocking might be too strong of a word. If you're using devcontainers, you need to manually edit the file to remove that feature and avoid committing it.) |
Dismissing my own review earlier. Context has been provided -- changing status to reflect that
One of the checks in the pipeline seems to be stuck? It appears as "pending", but the actual jobs were successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use forks.
I'd rather move the feature out of the devcontainer and use the docs for telling folks to manually install the golangci-lint.
The contributing guide already points to the installation guide for golangci-lint. Would you rather go the path of closing this PR and opening a new one that just removes the outdated dev container feature then? |
golangci-lint
since it's already included with ghcr.io/devcontainers/features/go:1
@vhvb1989 I've just realized that the I've updated the PR with the extra |
/check-enforcer override |
Thank you @PabloZaiden ! |
The old repo used for the golangci-lint feature is abandoned and a new working release was created in a new repo.
The current release properly supports ARM-based computers.
This PR Fixes #4505