azd env set add warning
#4547
Open
azd env set add warning
#4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanaXiong00
requested review from
ellismg,
wbreza,
vhvb1989,
hemarina and
weikanglim
as code owners
wbreza
approved these changes
Nov 13, 2024
cli/azd/cmd/env.go
Outdated
Comment on lines
165
to
170
| if strings.ToLower(existingKey) == lowerKey { | ||
| fmt.Printf( | ||
| "WARN: The environment variable '%v' already exists in the .env file with a different case.\n", | ||
| existingKey) | ||
| return | ||
| } |
There was a problem hiding this comment.
Please ensure warning messages are consistent with other warnings in the system. Messages should read "WARNING: [Message]" in Yellow by using our output.WithWarningFormat(...) helper function.
There was a problem hiding this comment.
@wbreza I have updated based on suggestions, please re-review.
weikanglim
reviewed
Nov 14, 2024
| conflictKeysStr := strings.Join(conflictKeys, " and ") | ||
| fmt.Print( | ||
| output.WithWarningFormat( | ||
| "WARNING: The environment variable %s already exists in the .env file with a different case.\n", |
There was a problem hiding this comment.
Let's hold off on merging, I'd like to continue with the requirements discussion here before we finalize the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #289.
azd env setadds warning about case sensitivity: warn if the same value is present but in mixed case.As shown in the figure below:
@rajeshkamal5050 for notification.