-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update bicep in lint-bicep to v0.31.92 #4565
base: main
Are you sure you want to change the base?
Conversation
8b20abe
to
7060465
Compare
@@ -40,9 +40,6 @@ param apimSku string = 'Consumption' | |||
@description('Id of the user or app to assign application roles') | |||
param principalId string = '' | |||
|
|||
@description('The base URL used by the web service for sending API requests') | |||
param webApiBaseUrl string = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter was complaining that this parameter was unused, which is true. So I removed it from here and from the associated main.parameters.json
file.
5a3b98e
to
062f68c
Compare
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: azd-starter-bicepRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/azd-starter-bicep -b pr/4565 View Changes | Compare Changes Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/4565 View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/4565 View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/4565 View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/4565 View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/4565 View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/4565 View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/4565 View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/4565 View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/4565 View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/4565 View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/4565 View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/4565You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/4565 View Changes | Compare Changes |
062f68c
to
22ec5ec
Compare
The current version that is installed on the runners (0.31.34) has some bugs around linting and causes lint warnings during our legs. These errors are not present on the latest Bicep CLI. Force an upgrade of the binary that is installed as part of the test runner to latest version. We should be able to remove this step once new image is built with an upgraded bicep (the `README.md` at https://github.com/actions/runner-images/tree/main/images/ubuntu has information about what is on the runner.)
22ec5ec
to
3463553
Compare
The current version that is installed on the runners (0.31.34) has some bugs around linting and causes lint warnings during our legs. These errors are not present on the latest Bicep CLI.
Force an upgrade of the binary that is installed as part of the test runner to latest version. We should be able to remove this step once new image is built with an upgraded bicep (the
README.md
at https://github.com/actions/runner-images/tree/main/images/ubuntu has information about what is on the runner.)