-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SiteExtension.proj to replace build-extension.ps1 #10168
base: dev
Are you sure you want to change the base?
Conversation
test/WebJobs.Script.Tests.Integration/WebJobs.Script.Tests.Integration.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Reviewed best I could based on the nature of the changes. Can we please make sure this is rebased on latest and compare the artifact output to ensure we're good (assuming this was already done, but worth calling out).
src/WebJobs.Script.SiteExtension/WebJobs.Script.SiteExtension.proj
Outdated
Show resolved
Hide resolved
@jviau Just as a heads up, we have recently updated the java worker version so that appears to be causing conflicts for your PR. |
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
This PR introduces a new project
WebHost.Script.SiteExtension
, which is a replacement forbuild-extension.ps1
. This project can be used viadotnet
CLI to restore, build, and publish all the artifacts needed for the Antares site extension. Note that this project has support for multi-targeting, but only targets a single TFM. This is in preparation for porting toin-proc
branch to keep the diff minimal between the two.Other Changes
update-hostreferences.ps1
, this is no longer used anywhereworkers.props
file. Left python out due to code owners, but ideally python will be moved there as well.ZipPublish.targets
.RuntimeIdentifiers
added toWebHost.csproj
. Having this set of identifiers listed improves the restore task (otherwise each time you want to use a different runtime, you have to re-restore).