Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address archboard review feedback for new Azure Identity features - renames #6000

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Address archboard review feedback for new Azure Identity features - renames #6000

merged 1 commit into from
Sep 18, 2024

Conversation

ahsonkhan
Copy link
Member

From Azure/azure-sdk#7886, part of #5960

  • Rename the ManagedIdentityIdType enum to ManagedIdentityIdKind (and GetManagedIdentityIdType() to GetManagedIdentityIdKind()).
  • Rename ManagedIdentityType to ManagedIdentityId.
  • Rename the options field from IdentityType to IdentityId.

@ahsonkhan ahsonkhan self-assigned this Sep 17, 2024
@ahsonkhan
Copy link
Member Author

ahsonkhan commented Sep 17, 2024 •
edited
Loading

We've reached PR/issue 6000! 🎉

antkmsft
antkmsft approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I recommend get an approval from Larry who I assume proposed these changes.

@ahsonkhan ahsonkhan merged commit d1cd23f into Azure:main Sep 18, 2024
67 checks passed
@ahsonkhan ahsonkhan deleted the MICredArchBoard branch September 18, 2024 23:07
@ahsonkhan ahsonkhan mentioned this pull request Sep 25, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickWinter RickWinter RickWinter approved these changes

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@antkmsft antkmsft antkmsft approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@gearama gearama Awaiting requested review from gearama gearama is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees

@ahsonkhan ahsonkhan

Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahsonkhan @RickWinter @LarryOsterman @antkmsft