-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do NOT REVIEW] V durgeshs/fix/beta5 audio format fix #47854
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties in CallConnectionProperties. (#44187)
* Added live tests for media streaming and transcription * Adding the live tests for media and transcription --------- Co-authored-by: Vinothini Dharmaraj <[email protected]>
* Added beta4 create connect api changes * updating to latest autorest for connect * updating the string url to uri * reverting beta4 changes * addresing Azure board review comments * updating connection properties * removing the changes for failed index * removing the unwanted changes * updating package version and removed unnecessary changes * Added connect api live test. (#44441) * Added connect api live test. * adding unit tests for connect api * removing the media subscription commented code --------- Co-authored-by: Vinothini Dharmaraj <[email protected]> * live test added one more scenario (#44609) * Added connect api live test. * adding unit tests for connect api * removing the media subscription commented code * Adding live test for connect api hang for all --------- Co-authored-by: Durgesh Suryawanshi <[email protected]> * updating the merge * adding tests for connect failed and play started --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: Durgesh Suryawanshi <[email protected]> Co-authored-by: Durgesh Suryawanshi <[email protected]>
v-vdharmaraj
requested review from
Kishp01,
thang-bit,
johngallardo,
abhinav-ghai,
Aashish93-stack,
sjiherzig,
sebrenna,
a team,
PallabPaul,
amruthashree18,
minnieliu,
paolamvhz,
shwali-msft,
allchiang-msft,
mikehang-msft,
gfeitosa-msft,
phermanov-msft,
ilyapaliakou-msft and
besh2014
as code owners
January 21, 2025 19:34
v-vdharmaraj
requested review from
sarangan12,
KevinBlasko,
srnagar,
ToddKingMSFT,
jairmyree and
gulopesd
January 21, 2025 19:34
alexmahonic
approved these changes
Jan 21, 2025
jsquire
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your changes on main
. Only those files that you're directly changing should be included in the PR.
v-vdharmaraj
changed the title
V durgeshs/fix/beta5 audio format fix
[Do NOT REVIEW] V durgeshs/fix/beta5 audio format fix
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.