Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default features of http-types #1619

Closed
wants to merge 1 commit into from
Closed

Conversation

omid
Copy link

@omid omid commented Feb 29, 2024

No description provided.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a reason as to why this change is necessary or recommended.

@omid
Copy link
Author

omid commented Feb 29, 2024

@heaths I'm not familiar with the source code that much, so my change can break the lib, but at least the tests I run passed.

I use azure sdk in a project and saw useless (to me!) and old dependencies which are attached to the not-actively-maintained http-types. And this change is to avoid including them, if I understood correctly.

@omid
Copy link
Author

omid commented Feb 29, 2024

OK, now I investigated more :/

http-types has some 3-year-old changes on master which are not yet released! So my change here is meaningless and wrong!

Rust ecosystem should think about this old http-types package with ~10M downloads!

Thanks @heaths

@omid omid closed this Feb 29, 2024
@svix-jplatte
Copy link

Related: #1644

@omid omid deleted the patch-1 branch May 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants