Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage]
get_blob_properties
forBlobClient
#2014base: main
Are you sure you want to change the base?
[Storage]
get_blob_properties
forBlobClient
#2014Changes from 9 commits
665b9b1
570f117
ed70266
625c6ae
345e6cc
ff58b75
a85712a
6add958
d695771
9dc8293
815536c
68fa493
23ea09d
9b1f702
160ec23
52d12a4
956175d
b8a7f97
c63cb2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other languages, I thought you can only get a
BlobClient
from aContainerClient
or something i.e., these aren't creatable. If so, they must be exported from both the crate root (re-exported) and from theclients
module in which all clients - creatable or gettable - are exported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you can construct these independently (python ex.):
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/tests/test_blob_client.py#L82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a string and not a
DateTimeOffset
which we use for times elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrt this comment, is there a currently accepted way to convert from RFC1123 strings (as returned by the service) ex:
creation_time: Some("Sat, 01 Feb 2025 00:17:37 GMT"
to aOffsetDateTime
object? I know you can provide a custom pattern query to parse, but I assume that if we haveOffsetDateTime
elsewhere we may have some common utility for this?