Automatically record and play back test recordings #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
previously approved these changes
Jan 29, 2025
|
@LarryOsterman I was touching yer' stuff. Shouldn't matter, but it's easier all around to require recorded/live tests return a |
heaths
dismissed
LarryOsterman’s stale review
As this is a draft, an early review is great but I don't recommend signing off just yet. More to come.
heaths
force-pushed
the
issue1876
branch
4 times, most recently
from
b9ff17d to
18ffb68
Compare
heaths
requested review from
RickWinter,
JeffreyRichter and
ronniegeraghty
as code owners
This is simpler to support in the `#[recorded::test]` macro and sets a good precedent we want to show users anyway instead of `unwrap()` or `expect()`.
The default single-threaded async runtime runner was deadlocking in `Recording::drop()`. I opened Azure#2049 to revisit this but I don't foresee any problem. We already don't support test-proxy on wasm32 and our mix of agents we do test on support multi-threaded async runtimes just fine.
We need to sanitize the headers later, but easier just to sanitize them all right now. This is still better than before which only showed how many headers were in the request.
RickWinter
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1876