Fix client invocation bug with multiple endpoints #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingsy97
force-pushed
the
siy/fix-invocation-bug
branch
from
427b44c to
0f8a61e
Compare
xingsy97
force-pushed
the
siy/fix-invocation-bug
branch
from
6f3059e to
9431689
Compare
TD2106
reviewed
Feb 19, 2025
src/Microsoft.Azure.SignalR.Common/ServiceConnections/MultiEndpointMessageWriter.cs
Show resolved
Hide resolved
TD2106
reviewed
Feb 19, 2025
src/Microsoft.Azure.SignalR/ClientInvocation/CallerClientResultsManager.cs
Show resolved
Hide resolved
vicancy
reviewed
Feb 19, 2025
| if (serviceMessage is ClientInvocationMessage invocationMessage) | ||
| { | ||
| // Accroding to target endpoints in method `WriteMultiEndpointMessageAsync` | ||
| _clientInvocationManager.Caller.SetAckNumber(invocationMessage.InvocationId, TargetEndpoints.Length); |
There was a problem hiding this comment.
when TargetEndpoints.Length is 0, the result is OK?
There was a problem hiding this comment.
class AckHandler could handle such condition correctly. Refer to its method SetExpectedCount
There was a problem hiding this comment.
xingsy97
force-pushed
the
siy/fix-invocation-bug
branch
from
075f8ed to
68b7aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)