fix AspNet productInfo #2168
Open
fix AspNet productInfo #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
tefa/fix-aspnet-header
branch
from
827676f to
515bb98
Compare
vicancy
reviewed
Feb 26, 2025
| protected abstract void SetCustomHeaders(IDictionary<string, string> headers); | ||
|
|
||
| private static void CheckHeaders(IDictionary<string, string> headers, string forbidPrefix) | ||
| private static void CheckHeadersPrefix(IDictionary<string, string> headers, string forbidPrefix) |
| { | ||
| var key = item.First().Key; | ||
| var key = item[0].Key; |
| return headers; | ||
| } | ||
|
|
||
| internal virtual void SetInternalHeaders(IDictionary<string, string> headers) | ||
| internal virtual void SetServerId(IDictionary<string, string> headers) |
There was a problem hiding this comment.
private is enough? We already have customServerIdProvider to hook in server id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the handling of headers in the
ConnectionFactoryclasses and updating relevant tests to ensure proper functionality. The key changes include refactoring methods for setting headers, adding a new method for setting the internal user agent, and updating test cases accordingly.Improvements to header handling:
src/Microsoft.Azure.SignalR.AspNet/ServerConnections/ConnectionFactory.cs: Added a new methodSetInternalUserAgentto handle setting the user agent header, addressing an issue with .NET Framework restrictions on reserved strings as header names.src/Microsoft.Azure.SignalR.Common/ServiceConnections/ConnectionFactoryBase.cs: Refactored methods to separate the setting of internal headers and user agent, and renamed methods for clarity. [1] [2] [3]src/Microsoft.Azure.SignalR.Management/ManagementConnectionFactory.cs: Updated method overrides to use the newSetInternalUserAgentmethod for setting the user agent header.Updates to test cases:
test/Microsoft.Azure.SignalR.AspNet.Tests/ConnectionFactoryTests.cs: Added new test cases to validate the correct setting of request headers, including the user agent and server ID.test/Microsoft.Azure.SignalR.Management.Tests/ManagementConnectionFactoryTests.cs: Updated existing test cases to reflect changes in user agent header values. [1] [2]test/Microsoft.Azure.SignalR.Tests/ConnectionFactoryTests.cs: Modified test cases to ensure proper handling of custom headers and validation of user agent header format. [1] [2]