Updating build to use Azure DevOps #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashimiz
requested review from
mathewc,
liliankasem,
brettsam,
fabiocav,
jviau,
kshyju,
madelinegordon,
soninaren,
surgupta-msft and
satvu
satvu
reviewed
Jan 4, 2023
| $ctx = New-AzureStorageContext $env:FILES_ACCOUNT_NAME $env:FILES_ACCOUNT_KEY | ||
| Set-AzureStorageBlobContent "$directoryPath/../../../buildoutput/tosign.zip" "webjobs" -Blob "$env:APPVEYOR_BUILD_VERSION.zip" -Context $ctx | ||
| Write-Host "Uploading signing job to storage." | ||
| # This will fail if the artifacts already exist. |
There was a problem hiding this comment.
great addition! love finding comments like this when I investigate issues.
brettsam
approved these changes
Jan 17, 2023
| testRunTitle: 'XUnit Tests' | ||
| condition: always() | ||
|
|
||
| - pwsh: .\tools\PollSigningResults.ps1 -buildVersion "$(buildVersion)" -isPr $$(isPr) -artifactDirectory "$(buildOutputDirectory)" -forceArtifacts $${{ parameters.force_artifacts }} -skipAssemblySigning $${{ parameters.skip_assembly_signing }} |
There was a problem hiding this comment.
Is the plan to move to the ADO signing task once this is in and stabilized?
There was a problem hiding this comment.
Good question; I would assume so. The goal of this work is a lift-and-shift to ADO with minimal adjustments to get things working in the new environment. We've got a high-level tracking item for enhancements identified during but outside the scope of the migration epic here: Azure/Azure-Functions#2272
@fabiocav to confirm, but I'll create a work item for this.
kashimiz
force-pushed
the
kashimiz/adomigration
branch
from
d274e80 to
60370da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
addresses Azure/azure-functions-host#8757
Pull request checklist
release_notes.mdAdditional information
A couple changes to note: