Skip to content

Commit

Permalink
feat: Added customDnsConfig output for PE (#2725)
Browse files Browse the repository at this point in the history
## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

This merge adds the output for customDnsConfigs for private endpoints. 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.private-endpoint](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.network.private-endpoint.yml/badge.svg?branch=johnlokerse%2FcustomDnsConfigs)](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.network.private-endpoint.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Sebastian Gräf <[email protected]>
  • Loading branch information
johnlokerse and segraef authored Jul 17, 2024
1 parent 77e9db5 commit b5fcc7a
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
1 change: 1 addition & 0 deletions avm/res/network/private-endpoint/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,7 @@ Tags to be applied on all resources/resource groups in this deployment.

| Output | Type | Description |
| :-- | :-- | :-- |
| `customDnsConfig` | | The custom DNS configurations of the private endpoint. |
| `groupId` | string | The group Id for the private endpoint Group. |
| `location` | string | The location the resource was deployed into. |
| `name` | string | The name of the private endpoint. |
Expand Down
3 changes: 3 additions & 0 deletions avm/res/network/private-endpoint/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ output name string = privateEndpoint.name
@description('The location the resource was deployed into.')
output location string = privateEndpoint.location

@description('The custom DNS configurations of the private endpoint.')
output customDnsConfig customDnsConfigType = privateEndpoint.properties.customDnsConfigs

@description('The group Id for the private endpoint Group.')
output groupId string = !empty(privateEndpoint.properties.manualPrivateLinkServiceConnections) && length(privateEndpoint.properties.manualPrivateLinkServiceConnections[0].properties.?groupIds) > 0
? privateEndpoint.properties.manualPrivateLinkServiceConnections[0].properties.?groupIds[0] ?? ''
Expand Down
9 changes: 8 additions & 1 deletion avm/res/network/private-endpoint/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.28.1.47646",
"templateHash": "12384550528617388749"
"templateHash": "8154060759198198360"
},
"name": "Private Endpoints",
"description": "This module deploys a Private Endpoint.",
Expand Down Expand Up @@ -595,6 +595,13 @@
},
"value": "[reference('privateEndpoint', '2023-11-01', 'full').location]"
},
"customDnsConfig": {
"$ref": "#/definitions/customDnsConfigType",
"metadata": {
"description": "The custom DNS configurations of the private endpoint."
},
"value": "[reference('privateEndpoint').customDnsConfigs]"
},
"groupId": {
"type": "string",
"metadata": {
Expand Down
4 changes: 2 additions & 2 deletions avm/res/network/private-endpoint/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.4",
"version": "0.5",
"pathFilters": [
"./main.json"
]
}
}

0 comments on commit b5fcc7a

Please sign in to comment.