feat: New module avm/ptn/authorization/pim-role-assignment #4431
+3,555
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies and adding new test modules for various scopes
…ecific role assignments
… as required and improve descriptions
…oved ownership tracking
…' to 'Contributor' for consistency across documentation and tests
…nd updated metadata
…ce resource removal logic
…n e2e test configuration
…s, add start and end date parameters
…nhance resource removal logic
…ule requests with AVM test justification
…e group name is empty
…rieve PrincipalId and RoleDefinitionId
…ents during removal
…eval filter for consistency
…'asTarget()' for accuracy
avm-team-linter
bot
added
the
Needs: Core Team 🧞
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
2 tasks
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
Comment on lines
+9
to
+10
| /avm/ptn/authorization/role-assignment/ @Azure/avm-ptn-authorization-roleassignment-module-owners-bicep @Azure/avm-module-reviewers-bicep | ||
| /avm/ptn/authorization/pim-role-assignment/ @Azure/avm-ptn-authorization-pimroleassignment-module-owners-bicep @Azure/avm-module-reviewers-bicep |
There was a problem hiding this comment.
I guess there one two many lines? 😄
There was a problem hiding this comment.
sorry I don't get the problem with this one 😄
There was a problem hiding this comment.
Currently shows errors as the teams are either not existing - or are not yet confirmed in the hierachy of teams (documented in the contribution guide)
There was a problem hiding this comment.
the teams are created, I can see them on GitHub teams. So maybe not approved yet ?
Comment on lines
141
to
145
| $null = New-AzRoleAssignmentScheduleRequest -Name $guid ` | ||
| -Scope $scope ` | ||
| -PrincipalId $pimRoleAssignmentPrinicpalId ` | ||
| -RequestType AdminRemove ` | ||
| -RoleDefinitionId $pimRoleAssignmentRoleDefinitionId |
There was a problem hiding this comment.
Suggested change
| $null = New-AzRoleAssignmentScheduleRequest -Name $guid ` | |
| -Scope $scope ` | |
| -PrincipalId $pimRoleAssignmentPrinicpalId ` | |
| -RequestType AdminRemove ` | |
| -RoleDefinitionId $pimRoleAssignmentRoleDefinitionId | |
| # To remove a scheduled request, a 'AdminRemove' request must be submitted | |
| $removalInputObject = @{ | |
| Name = $guid | |
| Scope = $scope | |
| PrincipalId = $pimRoleAssignmentPrinicpalId | |
| RequestType = 'AdminRemove' | |
| RoleDefinitionId = $pimRoleAssignmentRoleDefinitionId | |
| } | |
| $null = New-AzRoleAssignmentScheduleRequest @removalInputObject |
Splatting (using the backticks) is a bit of a 'debated' practice 😄
There was a problem hiding this comment.
Please also update to the other case :)
Comment on lines
18
to
20
| @description('Required. Principle ID of the user. This value is tenant-specific and must be stored in the CI Key Vault in a secret named \'userPrinicipalId\'.') | ||
| @secure() | ||
| param userPrinicipalId string = '' |
There was a problem hiding this comment.
Suggested change
| @description('Required. Principle ID of the user. This value is tenant-specific and must be stored in the CI Key Vault in a secret named \'userPrinicipalId\'.') | |
| @secure() | |
| param userPrinicipalId string = '' | |
| @description('Required. Principle ID of the user. This value is tenant-specific and must be stored in the CI Key Vault in a secret named \'CI-testUserObjectId\'.') | |
| @secure() | |
| param testUserObjectIdstring = '' |
Would recommend to rename the secret slightly. Also, please apply the update in the description to all test files using this secret. It must have the CI- prefix
There was a problem hiding this comment.
Just created the secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New pattern for PIM role assignments
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.