-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interface: update traffic manager APIs to support splitting weight behind serviceImport #233
base: main
Are you sure you want to change the base?
Conversation
e183b0d
to
927a304
Compare
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 12 changed files in this pull request and generated 2 comments.
Files not reviewed (7)
- api/v1alpha1/internalserviceexport_types.go: Evaluated as low risk
- api/v1alpha1/serviceexport_types.go: Evaluated as low risk
- api/v1alpha1/trafficmanagerbackend_types.go: Evaluated as low risk
- api/v1alpha1/trafficmanagerprofile_types.go: Evaluated as low risk
- api/v1alpha1/zz_generated.deepcopy.go: Evaluated as low risk
- config/crd/bases/networking.fleet.azure.com_internalserviceexports.yaml: Evaluated as low risk
- config/crd/bases/networking.fleet.azure.com_serviceexports.yaml: Evaluated as low risk
Comments suppressed due to low confidence (2)
pkg/controllers/hub/trafficmanagerbackend/controller_integration_test.go:761
- Ensure that the new 'From' field and weight calculations are covered by integration tests.
Endpoints: []fleetnetv1alpha1.TrafficManagerEndpointStatus{
pkg/controllers/hub/trafficmanagerbackend/controller.go:516
- Changing the parameter type from a pointer to a struct might cause unintended side effects. Ensure that this change is intentional and doesn't lead to performance issues or unexpected behavior.
func buildAcceptedEndpointStatus(endpoint *armtrafficmanager.Endpoint, cluster fleetnetv1alpha1.ClusterStatus) fleetnetv1alpha1.TrafficManagerEndpointStatus {
config/crd/bases/networking.fleet.azure.com_trafficmanagerbackends.yaml
Outdated
Show resolved
Hide resolved
behind serviceImport
927a304
to
47ddf4c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 79.66% 79.88% +0.21%
==========================================
Files 27 27
Lines 3840 3842 +2
==========================================
+ Hits 3059 3069 +10
+ Misses 625 618 -7
+ Partials 156 155 -1 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewable
for basic local testHow has this code been tested
Special notes for your reviewer