Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retries for popup and redirect #7270

Merged
merged 14 commits into from
Aug 28, 2024
Merged

Remove retries for popup and redirect #7270

merged 14 commits into from
Aug 28, 2024

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Aug 23, 2024 •
edited
Loading

This PR:

  • Fixes error condition in SilentIframeClient
  • Removes retries in PopupClient and associated PerformanceEvents
  • Removes retries in RedirectClient and associated changes in StandardController, BrowserCacheManager, and RedirectHandler

@github-actions github-actions bot added documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package labels Aug 23, 2024
@github-actions github-actions bot added the msal-node Related to msal-node package label Aug 23, 2024
@jo-arroyo jo-arroyo marked this pull request as ready for review August 23, 2024 21:03
tnorling
tnorling reviewed Aug 23, 2024
View reviewed changes
lib/msal-browser/src/config/Configuration.ts Outdated
OIDCOptions: Required<OIDCOptions>;
onRedirectNavigate?: (url: string) => boolean | void;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this released already we can't remove this. I think this was a good addition anyway even wihtout the retry

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks for catching that. Fixed!

tnorling
tnorling requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One breaking change that should be addressed otherwise looks good

@jo-arroyo jo-arroyo merged commit a7d6315 into dev Aug 28, 2024
8 of 9 checks passed
@jo-arroyo jo-arroyo deleted the remove-retry-redirect-popup branch August 28, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@peterzenz peterzenz peterzenz approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@trwalke trwalke Awaiting requested review from trwalke

@pmaytak pmaytak Awaiting requested review from pmaytak

@gladjohn gladjohn Awaiting requested review from gladjohn

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@rayluo rayluo Awaiting requested review from rayluo

@Avery-Dunn Avery-Dunn Awaiting requested review from Avery-Dunn

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jo-arroyo @tnorling @peterzenz