fixed ISSUE #99 When in ELCAssetTablePicker, make screenshots, the de… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- iOS 8 and above support with Photos Library. - iCloud sync support.
Photos Library Support.
Photos Framework Added.
Array count returns a unsigned long, but the numOfSelectedElements returns an int. Cast to an int to mask warning. This will work as long as the array does not have more than 2,147,483,647 elements in it.
Masks a implicit conversion warning (ALAssetorientation to UIImageOrientation. Looks like someone came up with the solution before me. http://stackoverflow.com/questions/26134719/ios-elcimagepicker-implicit-conversion-from-enumeration-type-alassetorientation
Mask warnings
NSInvalidArgumentException in ELCAlbumPickerController.m
nghiaphunguyen
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that previous logic run ALAssetLibrary on different threads. I fix it.
I also add @synchronize call to avoid multithreading locks
I add clearing console call on reload assets logic to fix issue with counting