Implemented Playlist builder #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\+ Creation of playlist with default name \+ implemented track search (opens #2) \+ Implemented adding tracks to list \+ Implemented setting custom playlist cover - Missing ability to select file to upload as cover (opens #3) - Missing saving and retrieving auth tokens for use in chron jobs + flag to enable (opens #4) - Known issue: some tracks cannot be found, although they were played on spotify to be scrobbled onto lastfm (see #2) - Missing flag to set a custom playlist name (opens #5) - missing flags to make playlists public and/or collaborative on creation. (opens #6)
- Regex-replacing ' and " in song titles (fixes #2) - found problem where the webserver receives the auth data from Spotify but never sends out a response. (opens #7) - gracefully stopping webserver at the end of the process - added functionality for the auth tab to be self-closing - set the LastFM api wrapper to use https instead of http
closes #3
closes #5 Also did a minor fix to the playlist building system, where sometimes a different version of the track was selected. Now Track titles have to match.
closes #6 also stated flag exclusivity in argument descriptions
Morril-2300
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ playlist creation, including name, cover and public/collaborative (see #3, #5, #6 implemented in 011cdc1, b783019, cadb4a9, 978640b)
+ track search (implemented in 011cdc1, ce9f8d1, cadb4a9)
+ adding tracks to playlist (implemented in 011cdc1)
+ QOL: Spotify authentication tab is self closing (implemented in ce9f8d1)
+ SECURITY: Bumped LastFM wrapper to use https (implemented in ce9f8d1)