Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/#82-커리큘럼_편집_모달창_구현
pipisebastian
requested review from
jasper200207,
llddang,
mun-kyeong and
yeonddori
그리고 편집모드 버튼에서 아이콘 버튼이 width가 긴데요, 이게 아이콘버튼 생각안하고 버튼 theme에서 width를 24로 맞춰놔서 이렇습니다.. 
|
jasper200207
approved these changes
Apr 30, 2024
|
|
||
| export default CurriculumCard; | ||
|
|
||
| // 'use client'; |
도균님이 icon_orange 라는 새로운 테마를 만든 것으로 압니다. |
llddang
reviewed
May 9, 2024
| }; | ||
|
|
||
| return ( | ||
| <Flex key={id.toString()} align="center" gap="4" px="4"> |
There was a problem hiding this comment.
이거 혹시 왜 string을 붙이신 걸까요?
key={id} 해도 괜찮을 것 같습니다
…into feature/#82-커리큘럼_편집_모달창_구현
yeonddori
reviewed
May 9, 2024
Comment on lines
17
to
25
| <IconButton | ||
| color="white" | ||
| bg="green_dark" | ||
| _hover={{ bg: 'green_dark' }} | ||
| aria-label="" | ||
| icon={<BiArrowBack />} | ||
| onClick={onActionModalOpen} | ||
| size="icon_sm" | ||
| /> |
There was a problem hiding this comment.
이 부분 바꾸려고 해놓으신 거겠죠..?
갑자기 초록 동그라미밖에 안보여서 당황했습니다😯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
작업 상세 설명
해당 링크를 봤을때, 라이브러리 개발자쪽에서 수정을 해야하는 것 같습니다! 해당 레포에서도, 이슈에 고쳐달라!라고 적혀져 있더라구요.
그래서 임시방편으로 해당 코드를 적어주면, 워닝은 뜨지 않더라구요! ([참고링크] (Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. at {Component} recharts/recharts#3615))
리뷰 요구 사항
미리 보기