client: fix bug where avg_ncpus for anonymous platform apps defaults to zero #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulpine05
reviewed
Jan 17, 2025
| @@ -856,7 +856,8 @@ int CLIENT_STATE::write_state_file_if_needed() { | |||
|
|
|||
| // look for app_versions.xml file in project dir. | |||
| // If find, get app versions from there, | |||
| // and use "anonymous platform" mechanism for this project | |||
There was a problem hiding this comment.
Apologies for being the grammar police, but shouldn't the line above say "If found" instead of "If find"?
There was a problem hiding this comment.
I think that 'If find' is comment-shorthand for 'If you find it'.
AenBleidd
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- client/client_state.cpp: Language not supported
- client/client_types.cpp: Language not supported
- client/cs_statefile.cpp: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6012