Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test round trip #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

patrix252
Copy link

This PR adds some simple tests to check that string round-trip conversion of all objects implementing from_str works fine.

In addition, I've also formatted the code with cargo +nightly fmt --all.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.1%. Comparing base (f3ce1c3) to head (36d682c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #74     +/-   ##
=======================================
+ Coverage     0.0%   5.1%   +5.1%     
=======================================
  Files          24     24             
  Lines        2159   2215     +56     
=======================================
+ Hits            0    113    +113     
+ Misses       2159   2102     -57     
Flag Coverage Δ
rust 5.1% <100.0%> (+5.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member

Thank you very much and congrats with the first time contribution!

Re cargo fmt, this is a new nightly version which once again changed rules with no notice. I will fix it by using edition_style new option in cargofmt.toml and will ask you to rebase after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants