Skip to content

Commit

Permalink
No longer use webdriver_manager, selenium can install chrome itself
Browse files Browse the repository at this point in the history
  • Loading branch information
nstephenh committed Sep 4, 2024
1 parent abf357a commit 2ec1610
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-in-new-recruit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: apt list --installed
# Need to fetch reqs if needed
- name: Installing all necessary packages
run: pip install webdriver-manager selenium
run: pip install selenium
- name: Run tests
run: python3 tests.py
working-directory: horus-heresy/tests/
Expand Down
4 changes: 0 additions & 4 deletions tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
import selenium.webdriver.support.ui as ui
import selenium.webdriver.support.expected_conditions as EC

from selenium.webdriver.chrome.service import Service as ChromeService
from webdriver_manager.chrome import ChromeDriverManager


class GameTests(unittest.TestCase):
debug = False
Expand All @@ -23,7 +20,6 @@ def setUp(self):
options.add_argument('--headless')

driver = webdriver.Chrome(
service=ChromeService(ChromeDriverManager().install()),
options=options)
driver.delete_all_cookies()
self.wait = ui.WebDriverWait(driver, 30) # timeout after 30 seconds
Expand Down

0 comments on commit 2ec1610

Please sign in to comment.