-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boston Voter App: Final merge of dev with main, project done woohoo! #54
Conversation
Boston Voter App: Active element fix for internal linking buttons
Ballot initiatives
✅ Deploy Preview for pitne-voter canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment!
server/.env
Outdated
@@ -0,0 +1,3 @@ | |||
GOOGLE_CIVIC_API_KEY=AIzaSyDjSjXjosp_JcNvXWEjTgwYEHeHs9o2y8U |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this key needs to be removed (keys are not generally public info and someone like Michelle can store it!). If this is a public key that is not associated with you, an email, etc., then it would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this file would be udpated to
GOOGLE_CIVIC_API_KEY=
And the readme would have info about how to fill it in
No description provided.