Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boston Voter App: Final merge of dev with main, project done woohoo! #54

Closed
wants to merge 364 commits into from

Conversation

eelkus01
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for pitne-voter canceled.

Name Link
🔨 Latest commit ef7877f
🔍 Latest deploy log https://app.netlify.com/sites/pitne-voter/deploys/667edf6da90d6a0008fadf67

@eelkus01 eelkus01 requested a review from colettebas June 28, 2024 15:22
Copy link
Collaborator

@jasonjiang9142 jasonjiang9142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Collaborator

@colettebas colettebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment!

server/.env Outdated
@@ -0,0 +1,3 @@
GOOGLE_CIVIC_API_KEY=AIzaSyDjSjXjosp_JcNvXWEjTgwYEHeHs9o2y8U
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this key needs to be removed (keys are not generally public info and someone like Michelle can store it!). If this is a public key that is not associated with you, an email, etc., then it would be fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this file would be udpated to
GOOGLE_CIVIC_API_KEY=
And the readme would have info about how to fill it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants