bug(file): fix for #95

[dzmitry-lahoda]

No description provided.

[mlech-reef]

@dzmitry-lahoda thank you for the fix. Looks like old file versions created before content_md5 field was added do not have it. I believe it was before the first version of this provider. Have you imported some old file into the terraform state?

Regarding the nix flake, I understand you use it to have preinstalled python toolset, however it is not something we want to maintain, and it is not compatible with the rest of this provider, e.g. python-bindings/requirements-dev.txt. I kindly ask you to remove it from this PR. You can add it to the gitignore if you want to use it for yourself.

Please also add an appropriate entry to the CHANGELOG.md, otherwise the CI will fail.

Best regards,
Maciej Lech

[dzmitry-lahoda]

these files are not old 100%.

i just created file version resource two days ago with whatever provider version published in registry at that time.

all was created 2 days ago. i did not imported anything. resource creation fails with error.

https://github.com/n1xyz/n1.nix/blob/dz/1/infra/base/.terraform.lock.hcl

[mlech-reef]

these files are not old 100%.

i just created file version resource two days ago with whatever provider version published in registry at that time.

Ok, as I see, according to the B2 API docs these fields are optional, so having them optional here make perfect sense. Thanks

[mlech-reef]

Put it under Unreleased and not 0.9.0:

## [Unreleased]

### Fixed
* Marked md5 and sha1 hashes as optional

[mlech-reef]

I have looked more deeply into this problem, and unfortunately:

1. your solution doesn't work
2. setting Optional and Computed has another undesired outcome

Ad. 1.
The reason it doesn't work is how we handle response from the python SDK. We require every field to be returned.

Ad. 2.
The undesired behavior is because of:

// Computed indicates whether the provider may return its own value for
// this attribute or not. Computed cannot be used with Required. If
// Required and Optional are both false, the attribute will be considered
// "read only" for the practitioner, with only the provider able to set
// its value.
Computed bool

It means, with Optional, terraforms allows setting content_md5, e.g.:

resource "b2_bucket_file_version" "test" {
  bucket_id    = b2_bucket.test.id
  file_name    = "file.txt"
  source       = "file.txt"
  content_type = "octet/stream"
  content_md5  = "test"
}

Without that, it throws Error: Value for unconfigurable attribute which is the desired behavior.

---

I was able to solve the problem differently. I will create a new PR.

BR/ Maciej Lech

[mlech-reef]

Also, it looks like for the large files, sha1 is set to "none" string and md5 is None and excluded from the SDK response.

[mlech-reef]

A new PR #97