Check interfaces that extend other interfaces. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, then the signature must be compatible. - Check interfaces "implemented" by an abstract base class. The base class doesn't need to actually implement, any non-abstract classes do.
jongardiner
commented
Jul 10, 2024
| @@ -203,13 +175,16 @@ protected function implementsMethod(Class_ $node, $interfaceMethod) { | |||
| */ | |||
| public function run($fileName, Node $node, ClassLike $inside = null, Scope $scope = null) { | |||
| if ($node instanceof Class_) { | |||
| if ($node->implements) { | |||
| if ($node->implements || $node->extends) { | |||
There was a problem hiding this comment.
This is the meat of the change. If a class implements OR extends any class, then we build a deep list of interfaces and confirm that you implement all the methods.
bknutson123
approved these changes
Jul 10, 2024
jongardiner
commented
Jul 10, 2024
| $this->processNodeImplements($fileName, $node); | ||
| } | ||
| if ($node->extends) { | ||
| $this->processNodeExtends($fileName, $node); | ||
| } | ||
| } | ||
| if ($node instanceof Interface_ && $node->extends) { | ||
| $this->processNodeImplements($fileName, $node); | ||
| } |
There was a problem hiding this comment.
This is a new check. If you have one interface that extends other interfaces, then we make sure that any common methods have compatible signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both list a method, then the signature must be compatible.