[SPN-1440] Web Api Documentation Check and Deprecated API Attribute Metric #125
+222
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… report on deprecated web APIs
bknutson123
changed the base branch from
master
to
BK/integators/SPN-1438/guardrailDeprecatedMetric
|
I'm still subscribed to updates here ha. Just wanted to pop in and say I'm glad you folks are doin' all the good things — hope it's going well! |
jlesueur
reviewed
Jan 21, 2025
jlesueur
approved these changes
Jan 21, 2025
jlesueur
reviewed
Jan 21, 2025
| use PhpParser\Node; | ||
| use PhpParser\Node\Stmt\ClassLike; | ||
|
|
||
| class WebApiDocumentationCheck extends BaseCheck { |
There was a problem hiding this comment.
If we want to talk about names, we might name this something a bit more specifically aimed at OA attributes?
…tric' into BK/integators/SPN-1440/deprecatedApiAttributeMetric # Conflicts: # src/Checks/ErrorConstants.php # src/NodeVisitors/StaticAnalyzer.php # tests/units/Checks/TestTemplates.php
bknutson123
merged commit 40ce6a4
into
BK/integators/SPN-1438/guardrailDeprecatedMetric
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.