Add attributes to ClassMethod abstraction #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or ClassMethod and ReflectedClassMethod so that we can inspect method attributes tests. Also, change analysis rate display to only run in an interactive TTY.
… into jgardiner/attribute-abstraction
…ty function for filtering of list of potential child classes by their ancestor.
bknutson123
approved these changes
Feb 7, 2024
Support for "true", "false", "null" as declared return types. 8.2 Support for typed constants 8.3 Checks for ?null as an illegal type (nullable null)
Support for "true", "false", "null" as declared return types. 8.2 Support for typed constants 8.3 Checks for ?null as an illegal type (nullable null)
Support for "true", "false", "null" as declared return types. 8.2 Support for typed constants 8.3 Checks for ?null as an illegal type (nullable null)
bknutson123
reviewed
Feb 15, 2024
| } | ||
|
|
||
| function run($fileName, Node $node, ClassLike $inside = null, Scope $scope = null) { | ||
| if ($node instanceof ClassConst) { |
There was a problem hiding this comment.
Wouldn't the node here always be an instance of ClassConst?
There was a problem hiding this comment.
Yes. I use the if to cast them so that static analyzers will know what we do about the type.
bknutson123
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, pretty print when outputting to a TTY.