[이지우] 과제 제출합니다 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 임시 사진으로 배경을 한 뒤 사진 위에 들어갈 요소들의 위치를 도트를 이용하여 잡아놓았다
- 배경에 사진을 추가하였고 글씨색을 바꾸어주었다
- 글씨, 버튼의 위치를 디자인과 동일하게 만들어주었다
- 사진위에 불투명 회색을 깔아줬고 모든 요소가 화면 중간에 배치되도록 하였다
SEOKKAMONI
requested changes
Jul 18, 2023
arkk200
requested changes
Jul 18, 2023
styles/text.css
Outdated
Comment on lines
5
to
25
| .text{ | ||
| width: 457px; | ||
| height: 188px; | ||
| line-height: 93.6px; | ||
| font-family: Pretendard,'Noto Sans KR', sans-serif; | ||
| font-weight: 700; | ||
| font-size: 72px; | ||
| letter-spacing: -1.5px; | ||
| color: #fff; | ||
| } | ||
| .text2{ | ||
| height: 82px; | ||
| padding-top: 24px; | ||
| font-family: Pretendard,'Noto Sans KR', sans-serif; | ||
| font-weight: 400; | ||
| font-size: 18px; | ||
| line-height: 28.8px; | ||
| letter-spacing: -0.15px; | ||
| vertical-align: bottom; | ||
| color: #BBBCC2; | ||
| } |
-코드 리뷰를 해주신 것을 토대로 코드를 수정함
-어둡게 되어 있는 이미지로 뒷배경 사진을 바꾸었다
|
수정하였습니다! |
-justify-content에서 center로 지정해주었던 걸 space-between으로 바꾸어 주었다
|
아 개웃경 수고하셧어요 |
arkk200
requested changes
Jul 19, 2023
-padding 값을 바꾸고 html 부분에 줬던 속성을 container에 주었으며 button 정렬에 position 대신 flex를 사용하였다
-text, container의 네이밍을 바꾸었다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🔨 Tasks
🙋🏻 More