generated from Bamdoliro/repository-generator
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[새기능] 특례입학 원서 폼 및 접수증 만들기 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FormController에 접수증 생성 API를 작성했어요.
- proof-of-application.html을 상수로 추가했어요.
- GenerateProofOfApplicationUseCaseTest를 생성했어요.
- 접수증을 위해서 proof-of-application.html을 만들었어요.
- GenerateProofOfApplicationUseCase를 추가했어요.
- GenerateProofOfApplicationUseCaseSpringBootTest를 작성했어요.
- FormControllerTest에 접수증 발급 테스트 코드를 작성했어요.
- 입학 전형 서류에 따라 특례 입학 대상자 심사 원서를 퍼블리싱 하였습니다.
- 접수증 발급 API를 작성했어요.
- 입학 전형 서류에 따라 특례 입학 대상자 확인서를 퍼블리싱 했어요.
- 특례입학 템플릿을 추가했어요.
- 입학 전형 서류에 따라 특례 입학 대상자 심사 원서의 누락된 부분을 미세 수정했어요.
- pdf 환경에서 :이 보이지 않는 것을 해결했어요.
- 특정 환경에서 글자들의 위치가 망가지는 것을 해결했어요.
- 입학전형 요강과 일치하게 스타일을 수정했어요.
6 tasks
이렇게 리뷰해주세요.🖐️ 규칙
🥬 우선순위리뷰 중요도에 따라 다음과 같은 prefix를 붙여주세요.
|
- 제출상태를 제외한 모든 원서에서 검증 조건을 최종제출, 승인, 접수가 아닌 원서를 검증하는 것으로 변경했어요.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
close #119
📄 개요
🔨 작업 내용
🏁 확인 사항
🙋🏻 덧붙일 말