[새기능] 입학등록원 & 금연서약서 제출 및 조회 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 입학 등록원 양식에 타임리프를 적용했어요.
- 입학 등록원 및 금연서약서 다운로드 API를 작성했어요.
- 쓰지 않는 줄 알고 죽여버린 금연서약서를 부활시켰어요.
- 금연서약서 및 입학등록원 다운로드 API 테스트 코드를 작성했어요.
- 금연서약서 및 입학등록원 다운로드 API를 문서화했어요.
- 금연서약서 및 입학등록원 업로드 API를 작성했어요.
- 금연서약서 및 입학등록원 업로드 API를 작성했어요.
- 금연서약서 및 입학등록원 업로드 API 테스트코드를 작성했어요.
- 금연서약서 및 입학등록원 업로드 API를 문서화했어요.
- 원서가 최종합격 상태일때만 presignedUrl을 발급받도록 변경했어요.
7 tasks
이렇게 리뷰해주세요.🖐️ 규칙
🥬 우선순위리뷰 중요도에 따라 다음과 같은 prefix를 붙여주세요.
|
cabbage16
reviewed
Nov 15, 2024
|
|
||
| @RequiredArgsConstructor | ||
| @UseCase | ||
| public class DownloadAdmissionAndPledgeUseCase { |
There was a problem hiding this comment.
P4) 양식만 다운로드 받는거니까 DownloadAdmissionAndPledgeFormatUseCase라고 해도 될 거 같아요.
- 입학등록원 양식 다운로드 기능이기때문에 뒤에 format을 붙였습니다.
|
gimhanul
reviewed
Nov 15, 2024
Comment on lines
+45
to
+58
| ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); | ||
| PdfDocument mergedDocument = new PdfDocument(new PdfWriter(outputStream)); | ||
| PdfMerger pdfMerger = new PdfMerger(mergedDocument); | ||
|
|
||
| templates | ||
| .stream() | ||
| .map((t) -> processTemplateService.execute(t, formMap)) | ||
| .map(generatePdfService::execute) | ||
| .forEach((s) -> mergePdfService.execute(pdfMerger, s)); | ||
|
|
||
| mergedDocument.close(); | ||
| pdfMerger.close(); | ||
|
|
||
| return new ByteArrayResource(outputStream.toByteArray()); |
There was a problem hiding this comment.
요거 왠지 공통 메서드일 거 같은데 분리하는 거 고려해봐도 좋을 거 같아욤
There was a problem hiding this comment.
마루 운영 끝난 후 반영하도록 하겠습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
close #165
📄 개요
🔨 작업 내용
🏁 확인 사항
🙋🏻 덧붙일 말