Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#81 #82

Merged
merged 16 commits into from
Jun 1, 2024
Merged

Feat/#81 #82

merged 16 commits into from
Jun 1, 2024

Conversation

jyj1289
Copy link
Member

@jyj1289 jyj1289 commented May 31, 2024

🎫 κ΄€λ ¨ 이슈

close #81


πŸ“„ κ°œμš”

μ „ν˜•λ³„ 1μ°¨ ν•©κ²©μžμ—κ²Œ λ©”μ‹œμ§€λ₯Ό λ³΄λ‚΄λŠ” κΈ°λŠ₯을 λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€.


πŸ”¨ μž‘μ—… λ‚΄μš©

  • μ „ν˜•λ³„ λ©”μ‹œμ§€ 보내기 APIλ₯Ό λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€.
  • MessageUseCase에 excute λ©”μ„œλ“œλ₯Ό μ˜€λ²„λ‘œλ”©ν•˜μ—¬ λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€.
  • λ§ˆμ΄μŠ€ν„°μ „ν˜•μ—μ„œ μΌλ°˜μ „ν˜•μœΌλ‘œ λ°”λ€” λ•Œ DB μƒμ—μ„œλŠ” λ°”λ€Œμ§€ μ•Šλ˜ 것을 DB μƒμ—μ„œλ„ λ°”λ€Œκ²Œ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

🏁 확인 사항

  • ν…ŒμŠ€νŠΈλ₯Ό μ™„λ£Œν–ˆλ‚˜μš”?
  • API λ¬Έμ„œλ₯Ό μž‘μ„±ν–ˆλ‚˜μš”?
  • μ½”λ“œ μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ 둜그, 주석, import 등을 μ‚­μ œν–ˆλ‚˜μš”?

πŸ™‹πŸ» 덧뢙일 말

jyj1289 added 16 commits May 28, 2024 17:33
@jyj1289
feat(#81) : λΆˆν•„μš”ν•œ μ½”λ“œ κ°œμ„ 
e57d2a9 
- SendMessageServiceμ—μ„œ formRepositoryλ₯Ό μ‚¬μš©ν•˜μ§€ μ•Šμ•„μ„œ μ œκ±°ν–ˆμ–΄μš”.
@jyj1289
feat(#81) : λ©”μ„œλ“œ μΆ”κ°€
53e18ec 
- λ§ˆμ΄μŠ€ν„°μ „ν˜•κ³Ό, λ§ˆμ΄μŠ€ν„°μ „ν˜•μ„ μ œμ™Έν•œ λͺ¨λ“  μ „ν˜•μ„ μ‘°νšŒν•˜κΈ° μœ„ν•΄μ„œ findMeisterTalentFirstRoundForm()κ³Ό findNotExistsMeisterTalentFirstRoundForm() λ©”μ„œλ“œλ₯Ό μΆ”κ°€ν–ˆμ–΄μš”
@jyj1289
feat(#81) : formRepository λ©”μ„œλ“œ κ΅¬ν˜„
626a4ee 
- λ§ˆμ΄μŠ€ν„°μ „ν˜•κ³Ό, λ§ˆμ΄μŠ€ν„°μ „ν˜•μ„ μ œμ™Έν•œ λͺ¨λ“  μ „ν˜•μ„ μ‘°νšŒν•˜κΈ° μœ„ν•΄μ„œ findMeisterTalentFirstRoundForm()κ³Ό findNotExistsMeisterTalentFirstRoundForm() λ©”μ„œλ“œλ₯Ό κ΅¬ν˜„ν–ˆμ–΄μš”.
@jyj1289
feat(#81) : μ „ν˜•λ³„ 메세지 λ©”μ„œλ“œ μΆ”κ°€
1eb26e2 
- μ „ν˜•λ³„λ‘œ λ©”μ‹œμ§€λ₯Ό 보내기 μœ„ν•΄μ„œ μ»¨νŠΈλ‘€λŸ¬μ— λ©”μ„œλ“œλ₯Ό μΆ”κ°€ν–ˆμ–΄μš”.
@jyj1289
refactor(#81) : DTO 이름 λ³€κ²½
d6e12fd 
- SendMessageByStatusRequest둜 이름을 λ³€κ²½ν–ˆμ–΄μš”
@jyj1289
feat(#81) : execute λ©”μ„œλ“œ μΆ”κ°€ 및 κ°œμ„ 
13a9a70 
- μ „ν˜•λ³„ λ©”μ‹œμ§€ 보내기 λ©”μ„œλ“œλ₯Ό λ§Œλ“€μ—ˆμ–΄μš”.
- λΉ„μ¦ˆλ‹ˆμŠ€ λ‘œμ§μ„ private λ©”μ„œλ“œλ‘œ λ°”κΎΈμ—ˆμ–΄μš”.
- κ²ΉμΉ˜λŠ” λ‘œμ§μ„ ν•˜λ‚˜μ˜ λ©”μ„œλ“œλ‘œ κ°œμ„ ν–ˆμ–΄μš”
@jyj1289
Merge branch 'develop' of https://github.com/Bamdoliro/marubase into …
5beb8ba 
…feat/#81
@jyj1289
feat(#81) : SendMessageByTypeRequest μΆ”κ°€
68b8f9a 
- SendMessageByTypeRequest DTOλ₯Ό μΆ”κ°€ν–ˆμ–΄μš”.
@jyj1289
fix(#81) : SendMessageRequest 이름 λ³€κ²½
135cf36 
- SendMessageRequestλ₯Ό SendMessageByStatusRequest둜 λ³€κ²½ν–ˆμ–΄μš”
@jyj1289
refactor(#81) : import 제거
79cec34 
- λΆˆν•„μš”ν•œ importλ₯Ό μ œκ±°ν–ˆμ–΄μš”.
@jyj1289
fix(#81) : 둜직 μˆ˜μ •
2c1470f 
- λ§ˆμ΄μŠ€ν„° μ „ν˜•μ—μ„œ μΌλ°˜μ „ν˜•μœΌλ‘œ 바뀐 μ›μ„œλŠ” getType()을 μ‚¬μš©ν–ˆμ„ λ•Œλ§Œ REGULAR둜 λ‚˜μ˜€κ³  μ‹€μ œ λ””λΉ„μ—λŠ” MEISTER_TALENT둜 λ“€μ–΄κ°€μ„œ 그룹별 λ©”μ‹œμ§€λ₯Ό 보낼 λ•Œ λ²ˆκ±°λ‘œμ›€μ΄ μžˆμ–΄μ„œ μ›μ„œ μ „ν˜• 자체λ₯Ό REGULAR둜 λ°”κΎΈκΈ°λ‘œ κ²°μ •ν–ˆμ–΄μš”.
@jyj1289
fix(#81) : boolean νƒ€μž… λ³€κ²½
48f997e 
- μš”μ²­ν•  λ•Œ 인식이 λ˜μ§€ μ•Šμ•„μ„œ boolean νƒ€μž…μ—μ„œ Boolean νƒ€μž…μœΌλ‘œ λ°”κΎΈμ—ˆμ–΄μš”
@jyj1289
docs(#81) : message.adoc
1fe3954 
- μš”μ²­ν•  λ•Œ 인식이 λ˜μ§€ μ•Šμ•„μ„œ boolean νƒ€μž…μ—μ„œ Boolean νƒ€μž…μœΌλ‘œ λ°”κΎΈμ—ˆμ–΄μš”
@jyj1289
feat(#81) : messageControllerTest μΆ”κ°€
7d8f19e 
- /message/type ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν–ˆμ–΄μš”.
@jyj1289
fix(#81) : ν…ŒμŠ€νŠΈ μ½”λ“œ μ‚­μ œ
dc71040 
- ν…ŒμŠ€νŠΈλ₯Ό μœ„ν•œ printlnμ½”λ“œλ₯Ό μ‚­μ œν–ˆμ–΄μš”
@jyj1289
feat(#81) : μ „ν˜•λ³„ λ©”μ‹œμ§€ 보내기 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
ce3304e 
- μ „ν˜•λ³„ λ©”μ‹œμ§€ 보내기 ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μž‘μ„±ν–ˆμ–΄μš”.
@jyj1289 jyj1289 requested a review from a team as a code owner May 31, 2024 08:40
@jyj1289 jyj1289 linked an issue May 31, 2024 that may be closed by this pull request
[μƒˆκΈ°λŠ₯] μ›μ„œ μ „ν˜•λ³„ λ©”μ‹œμ§€ 보내기 #81
Closed
7 tasks
@github-actions GitHub Actions
Copy link

μ΄λ ‡κ²Œ λ¦¬λ·°ν•΄μ£Όμ„Έμš”.

πŸ–οΈ κ·œμΉ™

  1. μ™œ κ°œμ„ μ΄ ν•„μš”ν•œμ§€ μΆ©λΆ„νžˆ μ„€λͺ…ν•΄μ£Όμ„Έμš”.
  2. 닡을 μ•Œλ €μ£ΌκΈ°λ³΄λ‹€λŠ” 슀슀둜 κ³ λ―Όν•˜κ³  κ°œμ„  방법을 선택할 수 있게 ν•΄μ£Όμ„Έμš”.
  3. μ½”λ“œλ₯Ό κΉ”λ”ν•˜κ²Œ μœ μ§€ν•˜κ³ , μΌκ΄€λ˜κ²Œ κ΅¬ν˜„ν•˜λ„λ‘ μ•ˆλ‚΄ν•΄ μ£Όμ„Έμš”.
  4. 리뷰 과정이 μˆ™μ œκ²€μ‚¬κ°€ μ•„λ‹Œ ν•™μŠ΅κ³Όμ •μœΌλ‘œ λŠλ‚„ 수 있게 리뷰해 μ£Όμ„Έμš”.
  5. 리뷰λ₯Ό μœ„ν•œ 리뷰λ₯Ό ν•˜μ§€ λ§ˆμ„Έμš”. ν”Όλ“œλ°± ν•  게 μ—†μœΌλ©΄ μΉ­μ°¬ν•΄ μ£Όμ„Έμš”.

πŸ₯¬ μš°μ„ μˆœμœ„

리뷰 μ€‘μš”λ„μ— 따라 λ‹€μŒκ³Ό 같은 prefixλ₯Ό λΆ™μ—¬μ£Όμ„Έμš”.

μ˜ˆμ‹œ - P5) μ“Έλͺ¨μ—†λŠ” 주석 μ‚­μ œν•΄μ£Όμ„Έμš”.

  • P1: κΌ­ λ°˜μ˜ν•΄μ£Όμ„Έμš” (Request changes)
  • P2: 적극적으둜 κ³ λ €ν•΄μ£Όμ„Έμš” (Request changes)
  • P3: μ›¬λ§Œν•˜λ©΄ λ°˜μ˜ν•΄ μ£Όμ„Έμš” (Comment)
  • P4: λ°˜μ˜ν•΄λ„ μ’‹κ³  λ„˜μ–΄κ°€λ„ μ’‹μŠ΅λ‹ˆλ‹€ (Approve)
  • P5: κ·Έλƒ₯ μ‚¬μ†Œν•œ μ˜κ²¬μž…λ‹ˆλ‹€ (Approve)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jyj1289 jyj1289 merged commit 9fefb8b into develop Jun 1, 2024
3 checks passed
@jyj1289 jyj1289 deleted the feat/#81 branch June 1, 2024 07:28
@jyj1289 jyj1289 added the μƒˆκΈ°λŠ₯ μƒˆλ‘œμš΄ κΈ°λŠ₯ 개발 label Jun 1, 2024
@jyj1289 jyj1289 restored the feat/#81 branch June 11, 2024 13:55
@jyj1289 jyj1289 deleted the feat/#81 branch June 11, 2024 13:59
@jyj1289 jyj1289 restored the feat/#81 branch June 11, 2024 14:06
@jyj1289 jyj1289 deleted the feat/#81 branch June 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
μƒˆκΈ°λŠ₯ μƒˆλ‘œμš΄ κΈ°λŠ₯ 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[μƒˆκΈ°λŠ₯] μ›μ„œ μ „ν˜•λ³„ λ©”μ‹œμ§€ 보내기
1 participant
@jyj1289