Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cantina/63 #224

Merged
merged 14 commits into from
Jan 13, 2025
Merged

cantina/63 #224

merged 14 commits into from
Jan 13, 2025

Conversation

mejango
Copy link
Contributor

@mejango mejango commented Jan 6, 2025

Description

What does this PR: do, how, why?

Limitations & risks

Are there any trade-off or new vulnarbility surface based on theses changes?

Check-list

  • Tests are covering the new feature
  • Code is natspec'd
  • Code is linted and formatted
  • I have run the test locally (and they pass)
  • I have rebased to the latest main commit (and tests still pass)

Interactions

These changes will impact the following contracts:

  • Directly:

  • Indirectly:

@xBA5ED
Copy link
Contributor

xBA5ED commented Jan 8, 2025

Im unsure if this issue is actually an issue, or perhaps im just not understanding it

@mejango
Copy link
Contributor Author

mejango commented Jan 8, 2025

Im unsure if this issue is actually an issue, or perhaps im just not understanding it

i dont think its actually an issue. just awkward and its nice to reserve 0 for wildcard/null purposes

@mejango mejango merged commit 589ee2b into main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants