Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jberc20 with a check fn #232

Merged
merged 5 commits into from
Jan 19, 2025
Merged

jberc20 with a check fn #232

merged 5 commits into from
Jan 19, 2025

Conversation

mejango
Copy link
Contributor

@mejango mejango commented Jan 17, 2025

Description

What does this PR: do, how, why?

Limitations & risks

Are there any trade-off or new vulnarbility surface based on theses changes?

Check-list

  • Tests are covering the new feature
  • Code is natspec'd
  • Code is linted and formatted
  • I have run the test locally (and they pass)
  • I have rebased to the latest main commit (and tests still pass)

Interactions

These changes will impact the following contracts:

  • Directly:

  • Indirectly:

xBA5ED
xBA5ED approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@xBA5ED xBA5ED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly limits flexibility a bit, but I don't see a better way of doing this. LGTM

@mejango mejango merged commit 13c85ed into main Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xBA5ED xBA5ED xBA5ED approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mejango @xBA5ED