Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clan sync #1024

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Clan sync #1024

merged 13 commits into from
Nov 21, 2024

Conversation

EgardA
Copy link
Contributor

@EgardA EgardA commented Oct 25, 2024 •
edited by garrettluskey
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Resolves #851
Resolves #852

Other information

@EgardA EgardA marked this pull request as draft October 25, 2024 22:38
@EgardA EgardA self-assigned this Oct 26, 2024
@EgardA EgardA marked this pull request as ready for review October 30, 2024 19:11
garrettluskey
garrettluskey requested changes Nov 20, 2024
View reviewed changes
source/E2E.Tests/Services/Clans/ClanSyncTests.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Handlers/ClanAdoptionHandler.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Handlers/ClanCompanionHandler.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Handlers/ClanInfluenceHandler.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Handlers/ClanKingdomHandler.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Handlers/ClanLeaderHandler.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Handlers/ClanRenownHandler.cs Outdated Show resolved Hide resolved
source/GameInterface/Services/Clans/Patches/ClanNameChangePatch.cs Show resolved Hide resolved
garrettluskey
garrettluskey previously approved these changes Nov 21, 2024
View reviewed changes
@garrettluskey
Copy link
Contributor

Please resolve conflicts then merge

@EgardA EgardA merged commit e0d747a into development Nov 21, 2024
1 of 2 checks passed
@EgardA EgardA deleted the ClanSync branch November 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettluskey garrettluskey garrettluskey left review comments

Assignees

@EgardA EgardA

Labels
None yet
Projects
Sync Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync: Clan Properties Sync: Clan Fields
2 participants
@EgardA @garrettluskey