Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kingdom properties sync #1072

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Kingdom properties sync #1072

merged 3 commits into from
Jan 22, 2025

Conversation

EgardA
Copy link
Contributor

@EgardA EgardA commented Jan 17, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Resolves #882

Other information

@EgardA EgardA self-assigned this Jan 17, 2025
Copy link
Contributor

@garrettluskey garrettluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix code factor then good to go, thank you for all of your very hard work :)

@EgardA EgardA merged commit b65d513 into development Jan 22, 2025
2 checks passed
@EgardA EgardA deleted the KingdomPropertiesSync branch January 22, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sync: Kingdom Properties
2 participants