Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip character creation options page #698

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Skip character creation options page #698

merged 1 commit into from
Nov 29, 2023

Conversation

martinprejsa
Copy link
Contributor

Move CharacterCreationFinishedPatch.cs -> CharacterCreationStatePatch.cs, renamed functions and objects inside, created NextStagePostfix to handle option page skip

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behaviour?

Options page is shown during character creation.

What is the new behaviour?

Options page is not shown during character creation.

@martinprejsa martinprejsa changed the title Skip Character Creation Options page Skip character creation options page Nov 29, 2023
@EgardA EgardA merged commit 7e4f85d into Bannerlord-Coop-Team:development Nov 29, 2023
1 check passed
Move CharacterCreationFinishedPatch.cs -> CharacterCreationStatePatch.cs, renamed functions and objects inside, created NextStagePostfix to handle option page skip
EgardA added a commit that referenced this pull request Nov 30, 2023
This reverts commit 7e4f85d, reversing
changes made to aac793c.
@7H30D0R
Copy link
Contributor

7H30D0R commented Jan 1, 2024

@EgardA did you mean to revert this PR?

@EgardA
Copy link
Contributor

EgardA commented Jan 1, 2024

@EgardA did you mean to revert this PR?

Several PRs were reverted at the same time due to some issues, this one might be applicable again. Was made in correspondence with wattman but I don't remember exactly the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants